Issue 1106042: Renamed constUnion class to ConstantUnion.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1106042: Renamed constUnion class to ConstantUnion. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by Alok Priyadarshi

Modified:
14 years, 7 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Renamed constUnion class to ConstantUnion.

Patch Set 1 #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -88 lines)			Patch
M	src/compiler/ConstantUnion.h	View	15 chunks	+27 lines, -27 lines	0 comments	Download
M	src/compiler/Intermediate.cpp	View	20 chunks	+32 lines, -32 lines	0 comments	Download
M	src/compiler/OutputGLSL.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/ParseHelper.cpp	View	8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/compiler/SymbolTable.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/compiler/SymbolTable.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/intermediate.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/compiler/localintermediate.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/compiler/parseConst.cpp	View	6 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Alok Priyadarshi

Verified that all targets compile fine. OutputHLSL does not refer to ConstantUnion explicitly.

14 years, 7 months ago (2010-05-05 14:52:53 UTC) #1

dgkoch

14 years, 7 months ago (2010-05-05 15:03:19 UTC) #2

Thanks for verifying.  LGTM

Daniel

On 2010/05/05 14:52:53, alokp wrote:
> Verified that all targets compile fine. OutputHLSL does not refer to
> ConstantUnion explicitly.

Expand All Messages | Collapse All Messages