Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(676)

Issue 110540043: \retrograde fails on slurs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

\retrograde fails on slurs The section "Retrograde" in the Notation Reference is affected. This became likely exposed with issue 2240; the corresponding regtest does not cover it. The problem was existent previously for slurs and other spans inside of chords. Also contains commit: Add slur to modal-transform regtest motif

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reword comment according to wl's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M input/regression/modal-transforms.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/modal-transforms.scm View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3
lemzwerg
LGTM. https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm File scm/modal-transforms.scm (right): https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm#newcode134 scm/modal-transforms.scm:134: \n(see). @code{transposer-factory}
9 years, 9 months ago (2014-07-13 15:27:37 UTC) #1
dak
On 2014/07/13 15:27:37, lemzwerg wrote: > LGTM. > > https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm > File scm/modal-transforms.scm (right): > ...
9 years, 9 months ago (2014-07-13 16:56:31 UTC) #2
lemzwerg
9 years, 9 months ago (2014-07-13 20:53:13 UTC) #3
Thanks.  LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b