Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16868)

Issue 110450044: Issue 2617: simple chord inversions take 2 octaves (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 2617: simple chord inversions take 2 octaves With this change, chord inversions transpose all notes following the inversion from the original chord down along with the inversion, as long as the result ends up below the root note of the uninverted chord. So with \chordmode { c:11 } => < c' e' g' bes' d'' f'' > we get \chordmode { c:11/e } => < e g bes c' d'' f'' > In order to have the Chord_name_engraver reconstruct the correct uninverted chord, all the additionally octavated note events are given an octavation property like the inversion event itself.

Patch Set 1 #

Patch Set 2 : f/f -> <f a' c''> #

Patch Set 3 : Adapt docs for inversion entry in chordmode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M Documentation/notation/chords.itely View 1 2 3 chunks +2 lines, -12 lines 0 comments Download
M lily/chord-name-engraver.cc View 2 chunks +15 lines, -21 lines 0 comments Download
M scm/chord-entry.scm View 1 2 chunks +37 lines, -21 lines 0 comments Download

Messages

Total messages: 2
dak
f/f -> <f a' c''>
9 years, 9 months ago (2014-07-10 11:27:09 UTC) #1
dak
9 years, 9 months ago (2014-07-10 13:27:16 UTC) #2
Adapt docs for inversion entry in chordmode
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b