Issue 110122: Fix collisions between hairpins and dynamic text spanners.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110122: Fix collisions between hairpins and dynamic text spanners. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by Neil Puttock

Modified:
14 years, 7 months ago

Reviewers:
Reinhold

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix collisions between hairpins and dynamic text spanners. * rename 'adjacent-hairpins to 'adjacent-spanners and add DynamicTextSpanner grobs in New_dynamic_engraver as well as hairpins * in Hairpin::print (), use renamed property to catch text spans and apply the appropriate amount of bound-padding

Patch Set 1 #

Patch Set 2 : Correct bound-padding glitch #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -68 lines)			Patch
M	lily/hairpin.cc	View	1	7 chunks	+42 lines, -32 lines	0 comments	Download
M	lily/new-dynamic-engraver.cc	View	1	10 chunks	+34 lines, -34 lines	0 comments	Download
M	scm/define-grob-properties.scm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Neil Puttock

14 years, 7 months ago (2009-09-06 21:19:18 UTC) #2

On 2009/09/01 11:41:15, Reinhold wrote:
> LGTM. But a regtest is missing ;-)

Ah, that was just me being lazy. :)

I'll add a regtest when I commit the patch.

I'm wondering whether adjacent-hairpins needs a convert rule.  I'm thinking not,
since it's an internal property, but there may be the odd adventurous user using
it for some advanced tweaks.

Any thoughts?

Regards,
Neil

Expand All Messages | Collapse All Messages