New original_tax field in account module

[carlospm, 2009-08-26 17:47:16]

Here you have the patch for the issue http://bugs.tryton.org/roundup/issue1078

It's against current trunk, however, I was only able to test it against 1.2
branch, because for some reason, trunk is not working for me right now (I'm not
able to connect with the server, so it's not caused by this patch).

I have a chart of accounts that use it at:
http://hg.pemas.es/tryton/account_es_abbreviated/ just in case you want to see
it in action.

Cheers

[ced1, 2009-08-26 20:54:28]

http://codereview.appspot.com/110087/diff/1/2
File tax.py (right):

http://codereview.appspot.com/110087/diff/1/2#newcode955
Line 955: # instead of just the tax group it belongs to.
Put this kind of comment in the help of the field instead.

[carlospm, 2009-08-27 08:19:16]

On 2009/08/26 20:54:28, ced wrote:
> http://codereview.appspot.com/110087/diff/1/2
> File tax.py (right):
> 
> http://codereview.appspot.com/110087/diff/1/2#newcode955
> Line 955: # instead of just the tax group it belongs to.
> Put this kind of comment in the help of the field instead.

Makes sense, done.

[ced1, 2009-08-27 08:36:17]

http://codereview.appspot.com/110087/diff/1005/1006
File tax.py (right):

http://codereview.appspot.com/110087/diff/1005/1006#newcode1004
Line 1004: 'based on it instead of just the tax group it belongs to.'
It must be: "The original tax template"

http://codereview.appspot.com/110087/diff/1005/1006#newcode1102
Line 1102: 'based on it instead of just the tax group it belongs to.'
I find the sentence doesn't explain well the field. Words like "allow us" look
strange.
I would say: "If the original tax is filled, the rule will be applied only for
this tax"
I think the help must explain the use instead of explaining why the field has
been added.

[carlospm, 2009-08-27 09:45:56]

Ok, applied

[ced1, 2009-08-27 09:52:23]

Looks good for me you can create the patch

[ced1, 2009-08-27 20:40:01]

can be closed