Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 110062: Synchronize venti/copy with Plan 9 version; add nwf's indented verbose mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by VenkateshSrinivas
Modified:
15 years, 2 months ago
Reviewers:
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Indentation fixes; sorry! #

Total comments: 3

Patch Set 3 : Match original code indentation, if statement spacing #

Total comments: 2

Patch Set 4 : Correct for loop spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -14 lines) Patch
M man/man1/venti.1 View 3 chunks +34 lines, -5 lines 0 comments Download
M src/cmd/venti/copy.c View 1 2 3 9 chunks +112 lines, -9 lines 0 comments Download

Messages

Total messages: 9
VenkateshSrinivas
15 years, 4 months ago (2009-08-21 16:13:41 UTC) #1
russcox_gmail.com
Thanks. A few small comments. Please fix and reupload with codereview -i 110062 http://codereview.appspot.com/110062/diff/1/3 File ...
15 years, 4 months ago (2009-08-21 16:32:22 UTC) #2
VenkateshSrinivas
15 years, 4 months ago (2009-08-21 16:36:04 UTC) #3
russcox_gmail.com
a few more nits, sorry http://codereview.appspot.com/110062/diff/7/9 File src/cmd/venti/copy.c (right): http://codereview.appspot.com/110062/diff/7/9#newcode94 Line 94: if (verbose) { ...
15 years, 4 months ago (2009-08-21 17:31:18 UTC) #4
VenkateshSrinivas
15 years, 4 months ago (2009-08-21 17:44:40 UTC) #5
russcox_gmail.com
sorry, for loops too. http://codereview.appspot.com/110062/diff/12/1004 File src/cmd/venti/copy.c (right): http://codereview.appspot.com/110062/diff/12/1004#newcode95 Line 95: for (i = 0; ...
15 years, 4 months ago (2009-08-21 18:24:51 UTC) #6
VenkateshSrinivas
15 years, 4 months ago (2009-08-21 18:32:18 UTC) #7
russcox_gmail.com
thanks! codebot: apply venti/copy: synchronize with Plan 9; indent in verbose mode
15 years, 4 months ago (2009-08-21 19:54:54 UTC) #8
old.codebot
15 years, 4 months ago (2009-08-21 19:56:10 UTC) #9
# codebot: apply

applied.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b