Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1787)

Issue 110050: Avoid crash in *Blitter::blitMask().

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by Stephen White
Modified:
15 years, 4 months ago
Reviewers:
reed, agl
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In MaskSuperBlitter::blitH(), iy shouldn't go negative, but it does, causing a crash later in the underlying blitter's blitMask(). For now, bail out instead of crashing. Also add some SkASSERT's to try to figure out where it's going wrong.

Patch Set 1 #

Patch Set 2 : Tweak whitespace and comment to match existing practice. #

Total comments: 2

Patch Set 3 : Fixed asserts to be SkFixed-friendly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
src/core/SkScan_AntiPath.cpp View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Stephen White
15 years, 4 months ago (2009-08-20 15:02:41 UTC) #1
Stephen White
15 years, 4 months ago (2009-08-20 15:03:38 UTC) #2
Stephen White
Tweak whitespace and comment to match existing practice.
15 years, 4 months ago (2009-08-20 20:39:57 UTC) #3
Stephen White
Hi Adam, I'm adding you as reviewer since Mike seems to be away for the ...
15 years, 4 months ago (2009-08-20 20:47:00 UTC) #4
reed
http://codereview.appspot.com/110050/diff/1001/6 File src/core/SkScan_AntiPath.cpp (right): http://codereview.appspot.com/110050/diff/1001/6#newcode369 Line 369: SkASSERT(ir.fTop <= (int) path.getBounds().fTop); The cast is no ...
15 years, 4 months ago (2009-08-20 20:51:13 UTC) #5
Stephen White
Fixed asserts to be SkFixed-friendly
15 years, 4 months ago (2009-08-20 21:11:51 UTC) #6
Stephen White
http://codereview.appspot.com/110050/diff/1001/6 File src/core/SkScan_AntiPath.cpp (right): http://codereview.appspot.com/110050/diff/1001/6#newcode369 Line 369: SkASSERT(ir.fTop <= (int) path.getBounds().fTop); On 2009/08/20 20:51:13, reed ...
15 years, 4 months ago (2009-08-20 21:38:55 UTC) #7
reed
15 years, 3 months ago (2009-08-21 20:45:51 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b