Tryton download script in python

[ced1, 2009-08-20 13:44:06]

http://codereview.appspot.com/110049/diff/7/8
File tryton-dev (right):

http://codereview.appspot.com/110049/diff/7/8#newcode124
Line 124: modules.append(module)
You can use a set instead of a list

[h.goebel, 2009-08-22 14:17:39]

http://codereview.appspot.com/110049/diff/1003/1004
File tryton-dev (right):

http://codereview.appspot.com/110049/diff/1003/1004#newcode122
Line 122: if module in modules:
Why should there be any need for check? Modules should be unique within each
repository, thus this check would never trigger.
Duplicate download off modules is checked just 4 lines later and work across
repositories.

[yangoon1, 2009-08-22 22:11:33]

http://codereview.appspot.com/110049/diff/1003/1004
File tryton-dev (right):

http://codereview.appspot.com/110049/diff/1003/1004#newcode122
Line 122: if module in modules:
On 2009/08/22 14:17:39, h.goebel wrote:
> Why should there be any need for check? Modules should be unique within each
> repository, thus this check would never trigger.
> Duplicate download off modules is checked just 4 lines later and work across
> repositories.

The regular expression just finds all modules, in all branches. It is just not
necessary to do needless clone trials and to have the message "already exists:
..." for duplicate module names on doing a completely fresh clone.

[h.goebel, 2009-08-25 13:54:06]

On 2009/08/22 22:11:33, yangoon wrote:

> The regular expression just finds all modules, in all branches. It is just not
> necessary to do needless clone trials and to have the message "already exists:
> ..." for duplicate module names on doing a completely fresh clone.

So the reg-exp is wrong and has to be corrected. No need for the 'modules'-set.

[h.goebel, 2009-10-07 07:35:31]

I've tested the latest patches for both with and without branch and it works as
expected. I suggest pushing the current version to roundup and replace old
tryton-dev.sh

[yangoon1, 2009-10-07 09:54:40]

On 2009/10/07 07:35:31, h.goebel wrote:
> I've tested the latest patches for both with and without branch and it works
as
> expected. I suggest pushing the current version to roundup and replace old
> tryton-dev.sh

I have tested this script, too, and it works ok now and provides extended
functionality.

Nevertheless I would propose a different name like tryton-download.

I don' t recommend to replace the old script tryton-dev.sh, but to put it as
alternative in the repos. This way manuals can refer to the one or the other and
don't need to be fixed.

h.goebel: would you please provide the patch against repos tryton-dev and put it
on https://bugs.tryton.org/roundup/issue1132?

Thx