Issue 110044: implement changes related to python-dev pep 3144 discussion.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110044: implement changes related to python-dev pep 3144 discussion. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by Peter Moody

Modified:
14 years, 8 months ago

Reviewers:
gregory.p.smith, Michael Shields, Matthew Smart, Matthew Flanagan

Base URL:
http://ipaddr-py.googlecode.com/svn/branches/2.0.x/

Visibility:
Public.

Description

* implement BaseIP.__hash__ * make IPvXNetwork objects immutable (remove ability to set the prefix)

Patch Set 2 : implement changes related to pep3144 discussion. #

Patch Set 3 : move .compressed() and .exploded() to IPAddrBase() #

Patch Set 4 : more discussion comments and small change to summarize_address_range #

Patch Set 5 : more pep3144 discussion changes. #

Patch Set 6 : make iter threadsafe #

Total comments: 8

Patch Set 7 : matt's comments + pep discussion comments. #

Patch Set 8 : ensure collapse is called with like versions + doc cleanup. #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+455 lines, -425 lines)			Patch
	M	ipaddr.py	View	1 2 3 4 5 6 7	46 chunks	+200 lines, -169 lines	0 comments	Download
	M	ipaddr_test.py	View	1 2 3 4 5 6 7	19 chunks	+255 lines, -256 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Matthew Flanagan

http://codereview.appspot.com/110044/diff/23/25 File ipaddr.py (right): http://codereview.appspot.com/110044/diff/23/25#newcode134 Line 134: def IPNetwork(address, host=False, version=None): It seems the host ...

14 years, 8 months ago (2009-08-25 11:57:24 UTC) #1

Peter Moody

thanks for the comments. I've uploaded the fixes. http://codereview.appspot.com/110044/diff/23/25 File ipaddr.py (right): http://codereview.appspot.com/110044/diff/23/25#newcode134 Line 134: ...

14 years, 8 months ago (2009-08-25 16:02:22 UTC) #2

Peter Moody

14 years, 8 months ago (2009-08-25 23:54:48 UTC) #3

I'm looking to publish a 2.0 release with this hopefully shortly.

any more comments?

Expand All Messages | Collapse All Messages