FSA Fix b/16139028 Part 2: Do not feed docids that are too long.

Examination of customer log files showed frequent exceptions thrown
from WindowsAclFileAttributesView.getFileSecurity() claiming that
"The filename, directory name, or volume label syntax is incorrect."
As it turned out, all these pathnames exceeded the maximum pathname
length of 260 characters. The too-long pathnames occur when we prepend
the UNC server + share syntax to the local pathname.

See:
http://msdn.microsoft.com/library/windows/desktop/aa365247.aspx

This change avoids feeding docids that are too long. The windows
version of newDocId() now throws IllegalArgumentException if the
supplied pathname is too long.

[mifern, 2014-07-11 01:44:10]

https://codereview.appspot.com/109680045/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/fs/FsAdaptor.java (right):

https://codereview.appspot.com/109680045/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/fs/FsAdaptor.java:479: } catch
(IllegalArgumentException e) {
delegate.getPath above hits the file system so ideally we need to check the path
length before calling delegate.getPath.

https://codereview.appspot.com/109680045/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java (right):

https://codereview.appspot.com/109680045/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java:266: if
(id.length() > WinNT.MAX_PATH) {
MAX_PATH includes the null terminator so valid lengths are less than MAX_PATH.

[pjo, 2014-07-11 17:38:40]

Thank you. Please apply Miguel's suggestion.  Otherwise LGTM.

[Brett, 2014-07-11 21:33:18]

https://codereview.appspot.com/109680045/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java (right):

https://codereview.appspot.com/109680045/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java:266: if
(id.length() > WinNT.MAX_PATH) {
On 2014/07/11 01:44:10, mifern wrote:
> MAX_PATH includes the null terminator so valid lengths are less than MAX_PATH.

Done.

[Brett, 2014-07-11 21:41:31]

Miguels feedback and add check to monitor thread.

[pjo, 2014-07-11 21:46:08]

Thank you.  LGTM.

Thanks for catching another "type" message.

[Brett, 2014-07-11 21:52:56]

Committed 11 July 2014 to Filesystem Adaptor:

To https://code.google.com/p/plexi.fs/
   fe9d9c9..f47e2c2  master -> master