|
Fix base attachments for slurs at linebreaks
- Acknowledge BarLines, but do not acknowledge SpanBars, since they
contain references to BarLines in all staves.
- For the base attachments (endpoints) of slurs that occur at
linebreaks, we want to calculate the X-offset based on one of the
slur's encompass objects: the "rightmost" for beginning of line, and
the "leftmost" for the end of line.
- Add "padding" for the slurs, so they do not touch the edge of the
leftmost or rightmost encompass object.
TODO: add more regression tests.
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+211 lines, -80 lines) |
Patch |
|
A |
input/regression/slur-bar-line.ly
|
View
|
1
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
|
A |
input/regression/slur-bar-line-broken.ly
|
View
|
|
1 chunk |
+16 lines, -0 lines |
0 comments
|
Download
|
|
M |
input/regression/slur-clef.ly
|
View
|
|
1 chunk |
+10 lines, -8 lines |
0 comments
|
Download
|
|
A |
input/regression/slur-line-break.ly
|
View
|
|
1 chunk |
+17 lines, -0 lines |
0 comments
|
Download
|
|
M |
lily/include/slur-scoring.hh
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
lily/include/spanner.hh
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
lily/phrasing-slur-engraver.cc
|
View
|
|
4 chunks |
+22 lines, -2 lines |
1 comment
|
Download
|
|
M |
lily/slur.cc
|
View
|
1
2
|
11 chunks |
+46 lines, -23 lines |
1 comment
|
Download
|
|
M |
lily/slur-engraver.cc
|
View
|
|
6 chunks |
+15 lines, -4 lines |
0 comments
|
Download
|
|
M |
lily/slur-scoring.cc
|
View
|
1
2
|
9 chunks |
+75 lines, -15 lines |
2 comments
|
Download
|
|
M |
lily/spanner.cc
|
View
|
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
Total messages: 1
|