Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1118)

Issue 109071: Fix base attachments for slurs at linebreaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by Patrick McCarty
Modified:
8 years, 1 month ago
Reviewers:
hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix base attachments for slurs at linebreaks - Acknowledge BarLines, but do not acknowledge SpanBars, since they contain references to BarLines in all staves. - For the base attachments (endpoints) of slurs that occur at linebreaks, we want to calculate the X-offset based on one of the slur's encompass objects: the "rightmost" for beginning of line, and the "leftmost" for the end of line. - Add "padding" for the slurs, so they do not touch the edge of the leftmost or rightmost encompass object. TODO: add more regression tests.

Patch Set 1 #

Patch Set 2 : A couple of small adjustments #

Patch Set 3 : Fix indentation #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -80 lines) Patch
A input/regression/slur-bar-line.ly View 1 1 chunk +9 lines, -0 lines 0 comments Download
A input/regression/slur-bar-line-broken.ly View 1 chunk +16 lines, -0 lines 0 comments Download
M input/regression/slur-clef.ly View 1 chunk +10 lines, -8 lines 0 comments Download
A input/regression/slur-line-break.ly View 1 chunk +17 lines, -0 lines 0 comments Download
M lily/include/slur-scoring.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/spanner.hh View 1 chunk +0 lines, -2 lines 0 comments Download
M lily/phrasing-slur-engraver.cc View 4 chunks +22 lines, -2 lines 1 comment Download
M lily/slur.cc View 1 2 11 chunks +46 lines, -23 lines 1 comment Download
M lily/slur-engraver.cc View 6 chunks +15 lines, -4 lines 0 comments Download
M lily/slur-scoring.cc View 1 2 9 chunks +75 lines, -15 lines 2 comments Download
M lily/spanner.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 1
hanwenn
14 years, 8 months ago (2009-08-23 17:23:09 UTC) #1
http://codereview.appspot.com/109071/diff/39/46
File lily/phrasing-slur-engraver.cc (right):

http://codereview.appspot.com/109071/diff/39/46#newcode147
Line 147: if (!g->internal_has_interface (ly_symbol2scm ("span-bar-interface")))
this will work in some cases, but is specific to the ordering of the prefatory
material and the existence of the barline.  It would better to catch an object
that has references to all of the breakable items.

http://codereview.appspot.com/109071/diff/39/48
File lily/slur-scoring.cc (right):

http://codereview.appspot.com/109071/diff/39/48#newcode411
Line 411: }
fold this code - left and right are symmetric.

http://codereview.appspot.com/109071/diff/39/48#newcode577
Line 577: x = (d == LEFT) ? (x + 0.25) : (x - 0.25);
dont use conditional

  x += -d * 0.25;

http://codereview.appspot.com/109071/diff/39/49
File lily/slur.cc (right):

http://codereview.appspot.com/109071/diff/39/49#newcode197
Line 197: - Is there a better way to accomplish this?
I think you should first make a test case that contains all combinations of key,
slur, clef, barline etc. at linebreaks, and go from there - hardcoding bar lines
here seems too limited
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b