LIB Do not send ACLs and Groups to GSA if markAllDocsAsPublic is true.

If markAllDocsAsPublic is true, feeding ACLs and Groups serves no
purpose.  This modifies DocIdSender to return immediately if
pushNamedResources() or pushGroupDefinitions() are called when
markAllDocsAsPublic is true.

When I added tests for this, I found some of the tests for
pushing named resources and groups normally were deficient,
so I beefed them up a bit.

[pjo, 2014-07-07 17:15:17]

LGTM.  Thank you

https://codereview.appspot.com/108400046/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/DocIdSender.java (right):

https://codereview.appspot.com/108400046/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/DocIdSender.java:146: return null;
add FINEST log?

https://codereview.appspot.com/108400046/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/DocIdSender.java:252: if (defs.isEmpty() ||
config.markAllDocsAsPublic()) {
add INFO or WARING? (higher level because is private 
and should not happen)

[Brett, 2014-07-08 21:18:24]

https://codereview.appspot.com/108400046/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/DocIdSender.java (right):

https://codereview.appspot.com/108400046/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/DocIdSender.java:146: return null;
On 2014/07/07 17:15:17, pjo wrote:
> add FINEST log?

Done.

https://codereview.appspot.com/108400046/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/DocIdSender.java:252: if (defs.isEmpty() ||
config.markAllDocsAsPublic()) {
On 2014/07/07 17:15:17, pjo wrote:
> add INFO or WARING? (higher level because is private 
> and should not happen)

Since I had to split the OR for logging anyways, I moved the test for
markAllDocsPublic to the public pushGroupDefinitions() and still log it as
finest.

[Brett, 2014-07-08 21:20:10]

Add logging.

[pjo, 2014-07-08 21:57:50]

LGTM.  Thank you.

[Brett, 2014-07-08 22:01:29]

Committed 08 July 2014 to Adaptor Library:

To https://code.google.com/p/plexi/
   3c40f45..0fd57ed  master -> master