Propagation and loss model enhanced

[faker.moatamri, 2009-08-18 08:54:35]

Here is a quick review of your code.

http://codereview.appspot.com/108047/diff/1/2
File examples/simple-wimax.cc (right):

http://codereview.appspot.com/108047/diff/1/2#newcode71
Line 71: BSRxTrace(std::string context, Ptr<const Packet> packet, Mac48Address
address,
please avoid white space changes in all your code.

http://codereview.appspot.com/108047/diff/1/2#newcode163
Line 163: ss1->SetModulationType(WimaxPhy::MODULATION_TYPE_QAM64_34);
why you removed the space before parentheses, it was good before

http://codereview.appspot.com/108047/diff/1/4
File scratch/wimax-ofdm-simulation.cc (right):

http://codereview.appspot.com/108047/diff/1/4#newcode45
Line 45: /*
remove all commented code

http://codereview.appspot.com/108047/diff/1/6
File src/devices/wimax/IPCS_BS_Packet_classifier.cc (right):

http://codereview.appspot.com/108047/diff/1/6#newcode69
Line 69: #if 0
if 0 is never used is it?

http://codereview.appspot.com/108047/diff/1/17
File src/devices/wimax/snr-to-block-error-rate-manager.cc (right):

http://codereview.appspot.com/108047/diff/1/17#newcode70
Line 70: case 0:
what about creating a vector m_RecordModulation[7]?

http://codereview.appspot.com/108047/diff/1/17#newcode161
Line 161: m_RecordModulation0 = 0;
creating an array would also reduce this function to two lines with a for loop

http://codereview.appspot.com/108047/diff/1/17#newcode187
Line 187: record = m_RecordModulation0;
it would be record = m_RecordModulation [modulation]

http://codereview.appspot.com/108047/diff/1/18
File src/devices/wimax/snr-to-block-error-rate-manager.h (right):

http://codereview.appspot.com/108047/diff/1/18#newcode50
Line 50: std::vector<SNRToBlockErrorRateRecord *> * m_RecordModulation0;
an array of vectors instead of 7 vectors

http://codereview.appspot.com/108047/diff/1/28
File src/devices/wimax/wimax-ofdm-phy/symbolCreator80216.cpp (right):

http://codereview.appspot.com/108047/diff/1/28#newcode103
Line 103: // std::cout << "temp(99)= " << temp(100 - 1) << std::endl;
remove all commented code