Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 108047: Propagation and loss model enhanced

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 3 weeks ago by faker.moatamri
Modified:
5 months, 3 weeks ago
Reviewers:
CC:
amine.ismail_sophia.inria.fr
SVN Base:
Visibility:
Public.

Patch Set 1

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M examples/simple-wimax.cc View 2 chunks 322 lines 2 comments Download
M examples/wscript View 1 chunk 259 lines 0 comments Download
A scratch/wimax-ofdm-simulation.cc View 1 chunk 281 lines 1 comment Download
M src/applications/UdpClientServer/udpServer.cc View 1 chunk 18 lines 0 comments Download
M src/devices/wimax/IPCS_BS_Packet_classifier.cc View 2 chunks 269 lines 1 comment Download
M src/devices/wimax/IPCS_Bind_parameter_manager.h View 1 chunk 13 lines 0 comments Download
M src/devices/wimax/IPCS_SS_Packet_classifier.cc View 1 chunk 15 lines 0 comments Download
M src/devices/wimax/bs-link-manager.cc View 2 chunks 29 lines 0 comments Download
M src/devices/wimax/connection-identifier-factory.cc View 1 chunk 15 lines 0 comments Download
M src/devices/wimax/cost231-propagation-model.cc View 4 chunks 84 lines 0 comments Download
M src/devices/wimax/cost231-propagation-model.h View 2 chunks 24 lines 0 comments Download
M src/devices/wimax/ofdm-wimax-phy.cc View 1 chunk 13 lines 0 comments Download
M src/devices/wimax/qos-parameter-set.h View 1 chunk 12 lines 0 comments Download
M src/devices/wimax/simpleOfdmWimaxPhy.cc View 12 chunks 202 lines 0 comments Download
M src/devices/wimax/simpleOfdmWimaxPhy.h View 5 chunks 68 lines 0 comments Download
A src/devices/wimax/snr-to-block-error-rate-manager.cc View 1 chunk 238 lines 3 comments Download
A src/devices/wimax/snr-to-block-error-rate-manager.h View 1 chunk 67 lines 1 comment Download
A src/devices/wimax/snr-to-block-error-rate-record.cc View 1 chunk 115 lines 0 comments Download
A src/devices/wimax/snr-to-block-error-rate-record.h View 1 chunk 75 lines 0 comments Download
M src/devices/wimax/wimax-bs-net-device.cc View 1 chunk 13 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/OFDMSymbolCreator80216.cpp View 1 chunk 94 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/OFDMSymbolCreator80216.h View 1 chunk 37 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/TransmissionSimulator.cpp View 1 chunk 127 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/TransmissionSimulator.h View 2 chunks 25 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/packetCreator.cpp View 4 chunks 40 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/pilotModulator80216.cpp View 1 chunk 117 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/symbolCreator80216.cpp View 1 chunk 340 lines 1 comment Download
M src/devices/wimax/wimax-ofdm-phy/symbolCreator80216.h View 1 chunk 35 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/testfiles/TransmissionSimulation.cpp View 2 chunks 174 lines 0 comments Download
M src/devices/wimax/wimax-ofdm-phy/testfiles/testTransmissionSimulator.cpp View 1 chunk 58 lines 0 comments Download
A src/devices/wimax/wimax-ofdm-phy/testfiles/wimax-ofdm-simulation.cc View 1 chunk 126 lines 0 comments Download
M src/devices/wimax/wscript View 2 chunks 26 lines 0 comments Download

Messages

Total messages: 1
faker.moatamri
5 months, 3 weeks ago
Here is a quick review of your code.

http://codereview.appspot.com/108047/diff/1/2
File examples/simple-wimax.cc (right):

http://codereview.appspot.com/108047/diff/1/2#newcode71
Line 71: BSRxTrace(std::string context, Ptr<const Packet> packet, Mac48Address
address,
please avoid white space changes in all your code.

http://codereview.appspot.com/108047/diff/1/2#newcode163
Line 163: ss1->SetModulationType(WimaxPhy::MODULATION_TYPE_QAM64_34);
why you removed the space before parentheses, it was good before

http://codereview.appspot.com/108047/diff/1/4
File scratch/wimax-ofdm-simulation.cc (right):

http://codereview.appspot.com/108047/diff/1/4#newcode45
Line 45: /*
remove all commented code

http://codereview.appspot.com/108047/diff/1/6
File src/devices/wimax/IPCS_BS_Packet_classifier.cc (right):

http://codereview.appspot.com/108047/diff/1/6#newcode69
Line 69: #if 0
if 0 is never used is it?

http://codereview.appspot.com/108047/diff/1/17
File src/devices/wimax/snr-to-block-error-rate-manager.cc (right):

http://codereview.appspot.com/108047/diff/1/17#newcode70
Line 70: case 0:
what about creating a vector m_RecordModulation[7]?

http://codereview.appspot.com/108047/diff/1/17#newcode161
Line 161: m_RecordModulation0 = 0;
creating an array would also reduce this function to two lines with a for loop

http://codereview.appspot.com/108047/diff/1/17#newcode187
Line 187: record = m_RecordModulation0;
it would be record = m_RecordModulation [modulation]

http://codereview.appspot.com/108047/diff/1/18
File src/devices/wimax/snr-to-block-error-rate-manager.h (right):

http://codereview.appspot.com/108047/diff/1/18#newcode50
Line 50: std::vector<SNRToBlockErrorRateRecord *> * m_RecordModulation0;
an array of vectors instead of 7 vectors

http://codereview.appspot.com/108047/diff/1/28
File src/devices/wimax/wimax-ofdm-phy/symbolCreator80216.cpp (right):

http://codereview.appspot.com/108047/diff/1/28#newcode103
Line 103: // std::cout << "temp(99)= " << temp(100 - 1) << std::endl;
remove all commented code
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld r511