Issue 107710043: FSA Fix b/16139028 Part1: Close DirectoryStreams to avoid leaking resources.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 107710043: FSA Fix b/16139028 Part1: Close DirectoryStreams to avoid leaking resources. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by Brett

Modified:
10 years, 5 months ago

Reviewers:
Brett Johnson, pjo, mifern

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

This change closes the DirectoryStreams in FsAdaptor, as they were being leaked. Also closes a Windows HANDLE in a finally clause in WindowFileDelegate.getLastAccessTime to ensure it gets called.

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -13 lines)			Patch
	M	src/com/google/enterprise/adaptor/fs/FsAdaptor.java	View		3 chunks	+10 lines, -4 lines	0 comments	Download
	M	src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java	View		1 chunk	+11 lines, -9 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mifern

https://codereview.appspot.com/107710043/diff/1/src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java File src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java (right): https://codereview.appspot.com/107710043/diff/1/src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java#newcode106 src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java:106: kernel32.GetFileTime(handle, null, accessTime, null); This is not needed. The ...

10 years, 5 months ago (2014-07-10 15:55:19 UTC) #2

Brett

10 years, 5 months ago (2014-07-10 23:06:57 UTC) #4

Committed 10 July 2014 to Filesystem Adaptor:

To https://code.google.com/p/plexi.fs/
   473e293..fe9d9c9  master -> master

Expand All Messages | Collapse All Messages