Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(221)

Issue 107046: Move `easy notation' print callback to scheme. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 7 months ago by Neil Puttock
Modified:
14 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Move `easy notation' print callback to scheme. * remove easy-notation.cc * add exported function ly:staff-symbol-staff-space to make accessing 'staff-space more convenient * add scheme implementation of ly:note-head::brew-ez-stencil to output-lib.scm * add convert-rule

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -114 lines) Patch
M lily/easy-notation.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M lily/staff-symbol-referencer-scheme.cc View 3 chunks +17 lines, -4 lines 1 comment Download
M ly/property-init.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M python/convertrules.py View 2 chunks +4 lines, -2 lines 0 comments Download
M scm/output-lib.scm View 2 chunks +37 lines, -1 line 0 comments Download
M scm/safe-lily.scm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
hanwenn
LGTM http://codereview.appspot.com/107046/diff/1/3 File lily/staff-symbol-referencer-scheme.cc (right): http://codereview.appspot.com/107046/diff/1/3#newcode45 Line 45: " with @var{grob}.") fix indents
14 years, 7 months ago (2009-08-17 02:57:15 UTC) #1
Neil Puttock
On 2009/08/17 02:57:15, hanwenn wrote: > http://codereview.appspot.com/107046/diff/1/3 > File lily/staff-symbol-referencer-scheme.cc (right): > > http://codereview.appspot.com/107046/diff/1/3#newcode45 > ...
14 years, 7 months ago (2009-08-17 21:40:16 UTC) #2
Patrick McCarty
14 years, 7 months ago (2009-08-17 22:05:58 UTC) #3
On 2009/08/17 21:40:16, Neil Puttock wrote:
> On 2009/08/17 02:57:15, hanwenn wrote:
> 
> > http://codereview.appspot.com/107046/diff/1/3
> > File lily/staff-symbol-referencer-scheme.cc (right):
> > 
> > http://codereview.appspot.com/107046/diff/1/3#newcode45
> > Line 45: " with @var{grob}.")
> > fix indents
> 
> Which ones?
> 
> I've double-checked the formatting in emacs and there are no changes.

I can see them on the "unified diff" page:

http://codereview.appspot.com/107046/diff/1/3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b