Issue 10700047: Documentation fix for compatibility with texinfo 5.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10700047: Documentation fix for compatibility with texinfo 5.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by Julien Rioux

Modified:
10 years, 9 months ago

Reviewers:
Graham Percival, lemzwerg

CC:
lilypond-devel_gnu.org

Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/

Visibility:
Public.

Description

Documentation fix for compatibility with texinfo 5.1 Patch by Don Armstrong, fixes issue 3382. http://code.google.com/p/lilypond/issues/detail?id=3382

Patch Set 2 : Revert @top change in changes.tely #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+25 lines, -16 lines)			Patch
Documentation/contributor/quick-start.itexi	View	1 chunk	+1 line, -1 line	0 comments	Download
Documentation/included/compile.itexi	View	7 chunks	+7 lines, -7 lines	0 comments	Download
Documentation/topdocs/INSTALL.texi	View	1 chunk	+9 lines, -0 lines	0 comments	Download
Documentation/usage/lilypond-book.itely	View	3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Graham Percival

LGTM https://codereview.appspot.com/10700047/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/10700047/diff/1/Documentation/changes.tely#newcode39 Documentation/changes.tely:39: @chapter New features in 2.18 since 2.16 Doesn't ...

10 years, 10 months ago (2013-07-11 02:38:16 UTC) #2

Julien Rioux

On 2013/07/11 02:38:16, Graham Percival wrote: > LGTM > > https://codereview.appspot.com/10700047/diff/1/Documentation/changes.tely > File Documentation/changes.tely (right): ...

10 years, 9 months ago (2013-07-16 21:14:50 UTC) #3

Julien Rioux

10 years, 9 months ago (2013-07-17 10:30:04 UTC) #5

On Tue, Jul 16, 2013 at 8:44 PM, Graham Percival
<graham@percival-music.ca>wrote:

> On Tue, Jul 16, 2013 at 09:14:50PM +0000, julien.rioux@gmail.com wrote:
> > I think this file is always included elsewhere, and does not require
> > @top itself.
> ...
> > Index: Documentation/changes.tely
> > diff --git a/Documentation/changes.tely b/Documentation/changes.tely
>
> Hmm.  It's a .tely instead of an .itely; by convention we call the
> included files .itely.  That's not to say that it's impossible
> that we broke that convention for some reason, but I'm suspicious.
> Has somebody checked that this patch can compile the docs from
> scratch?
>
> - Graham
>

I checked with Texinfo 5.1, but I've since reverted the @top change, and it
still compiles from scratch with Texinfo 5.1, so this change isn't
necessary for compatibility.

Julien

Expand All Messages | Collapse All Messages