Issue 10650: ZF-5238: Add support for looking up Zend_Gdata entry/feed versions when calling lookupNamespace().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10650: ZF-5238: Add support for looking up Zend_Gdata entry/feed versions when calling lookupNamespace(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Trevor Johns (Google)

Modified:
14 years, 9 months ago

Reviewers:
api.jhartmann-google

Visibility:
Public.

Description

ZF-5238: Add support for looking up Zend_Gdata entry/feed versions when calling lookupNamespace(). This also changes the default version for entries/feeds from null to 1, to retain backwards compatibility with non-versioned calls to Zend_Gdata_Base::lookupNamespace(). The file /tests/Zend/Gdata/_files/FeedSample1.xml has been renamed to /tests/Zend/Gdata/_files/FeedSampleV1.xml to be more descriptive.

Patch Set 1 #

Patch Set 2 : Renamed FeedSample1.xml to FeedSampleV1.xml #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+307 lines, -73 lines)			Patch
M	library/Zend/Gdata/App/FeedEntryParent.php	View		2 chunks	+37 lines, -1 line	0 comments	Download
M	tests/Zend/Gdata/App/EntryTest.php	View		2 chunks	+62 lines, -2 lines	0 comments	Download
M	tests/Zend/Gdata/App/FeedTest.php	View		1 chunk	+61 lines, -2 lines	0 comments	Download
M	tests/Zend/Gdata/FeedTest.php	View	1	5 chunks	+31 lines, -10 lines	0 comments	Download
M	tests/Zend/Gdata/_files/FeedSample1.xml	View	1	1 chunk	+0 lines, -58 lines	0 comments	Download
A	tests/Zend/Gdata/_files/FeedSampleV1.xml	View		1 chunk	+58 lines, -0 lines	0 comments	Download
A	tests/Zend/Gdata/_files/FeedSampleV2.xml	View		1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

api.jhartmann-google

LGTM with 1 minor suggestion. http://codereview.appspot.com/10650/diff/1/5 File tests/Zend/Gdata/FeedTest.php (right): http://codereview.appspot.com/10650/diff/1/5#newcode44 Line 44: 'Zend/Gdata/_files/FeedSample2.xml', I have ...

15 years, 4 months ago (2008-12-15 19:36:42 UTC) #2

Trevor Johns (Google)

15 years, 4 months ago (2008-12-15 23:29:50 UTC) #3

http://codereview.appspot.com/10650/diff/1/5
File tests/Zend/Gdata/FeedTest.php (right):

http://codereview.appspot.com/10650/diff/1/5#newcode44
Line 44: 'Zend/Gdata/_files/FeedSample2.xml',
On 2008/12/15 19:36:42, api.jhartmann wrote:
> I have been renaming all my v2 files as FileNameV2.xml. I don't think the '1'
> suffix had anything to do with versioning, so I used 'V2' ...

Done.

Expand All Messages | Collapse All Messages