Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1062)

Issue 105097: page: fix reading from stdin

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by jrm8005
Modified:
9 years, 1 month ago
Reviewers:
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : page: fix reading from stdin #

Total comments: 1

Patch Set 3 : page: fix reading from stdin #

Total comments: 1

Patch Set 4 : page: fix reading from stdin #

Total comments: 1

Patch Set 5 : page: fix reading from stdin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/cmd/page/page.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/cmd/page/page.c View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M src/cmd/page/util.c View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11
jrm8005
15 years, 5 months ago (2009-08-12 21:54:04 UTC) #1
russcox_gmail.com
thanks for doing this. a few small nits to clean up. resubmit with -i 105097 ...
15 years, 5 months ago (2009-08-12 22:15:58 UTC) #2
jrm8005
15 years, 5 months ago (2009-08-12 22:18:58 UTC) #3
russcox_gmail.com
http://codereview.appspot.com/105097/diff/8/9 File src/cmd/page/page.c (right): http://codereview.appspot.com/105097/diff/8/9#newcode87 Line 87: void cleanup() void cleanup(void) you missed this one
15 years, 5 months ago (2009-08-12 23:28:42 UTC) #4
jrm8005
15 years, 5 months ago (2009-08-12 23:35:44 UTC) #5
russcox_gmail.com
http://codereview.appspot.com/105097/diff/1005/12 File src/cmd/page/util.c (right): http://codereview.appspot.com/105097/diff/1005/12#newcode53 Line 53: extern char tempfile[40]; sorry, i missed this before. ...
15 years, 5 months ago (2009-08-18 06:16:19 UTC) #6
jrm8005
15 years, 5 months ago (2009-08-19 20:52:59 UTC) #7
russcox_gmail.com
so close... http://codereview.appspot.com/105097/diff/3001/3004 File src/cmd/page/util.c (right): http://codereview.appspot.com/105097/diff/3001/3004#newcode53 Line 53: extern char tempfile[40]; now this one ...
15 years, 4 months ago (2009-08-20 16:43:04 UTC) #8
jrm8005
15 years, 4 months ago (2009-08-20 17:02:05 UTC) #9
russcox_gmail.com
codebot: apply page: remove temporary file at program exit; fixes reading from stdin
15 years, 4 months ago (2009-08-20 18:37:42 UTC) #10
old.codebot
15 years, 4 months ago (2009-08-20 18:38:50 UTC) #11
# codebot: apply

applied.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b