Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 10506043: Adds version number to web page side bar (Issue 3367) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by PhilEHolmes
Modified:
10 years, 9 months ago
Reviewers:
Graham Percival, Mark Polesky, mail
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds version number to web page side bar (Issue 3367)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated following comments #

Patch Set 3 : Further upload to get issue number correct #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Documentation/lilypond-texi2html.init View 1 chunk +1 line, -1 line 0 comments Download
M python/auxiliar/postprocess_html.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
PhilEHolmes
Please review
10 years, 10 months ago (2013-06-24 16:32:25 UTC) #1
Graham Percival
LGTM
10 years, 10 months ago (2013-06-27 22:55:42 UTC) #2
Mark Polesky
https://codereview.appspot.com/10506043/diff/1/python/auxiliar/postprocess_html.py File python/auxiliar/postprocess_html.py (right): https://codereview.appspot.com/10506043/diff/1/python/auxiliar/postprocess_html.py#newcode60 python/auxiliar/postprocess_html.py:60: sidebar_version = _doc (' V%(package_version)s (%(branch_str)s).') Personally I prefer ...
10 years, 10 months ago (2013-06-30 05:48:26 UTC) #3
Mark Polesky
Also, I don't have time to compile right now, but I don't suppose it also ...
10 years, 10 months ago (2013-06-30 06:25:36 UTC) #4
mail_philholmes.net
----- Original Message ----- From: <markpolesky@gmail.com> To: <PhilEHolmes@googlemail.com>; <graham@percival-music.ca> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Sunday, June ...
10 years, 10 months ago (2013-06-30 10:03:55 UTC) #5
PhilEHolmes
Updated following comments
10 years, 10 months ago (2013-07-02 09:52:00 UTC) #6
PhilEHolmes
10 years, 10 months ago (2013-07-02 09:55:31 UTC) #7
Further upload to get issue number correct
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b