Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4669)

Issue 105045: SVG backend: Output a single SVG file for each page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by Patrick McCarty
Modified:
14 years, 8 months ago
Reviewers:
joeneeman
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

SVG backend: Output a single SVG file for each page Currently, if the SVG backend is used when creating multiple-page scores, a single SVG file is created, using the <pageSet> and <page> elements to delimit individual pages. Unfortunately, these elements are not supported by any known user agent, and they are part of a W3C Working Draft (SVG Print 1.2) that might not reach recommendation status for several years. At this point in time, a better solution is to output a single SVG file for each individual page. Outputters are created and closed for every page, and the unique filename suffixes are used for each successive page. We want to *eventually* add support for <pageSet> and <page> with a -d option, so the source code comments have been updated to reflect this.

Patch Set 1 #

Patch Set 2 : Revise according to Graham's comments #

Patch Set 3 : Update, revise, and move comments/docs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -81 lines) Patch
M Documentation/application/running.itely View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/framework-svg.scm View 1 2 1 chunk +65 lines, -71 lines 1 comment Download
M scm/output-svg.scm View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 1
joeneeman
14 years, 8 months ago (2009-08-07 23:56:48 UTC) #1
lgtm. You can ignore my nitpicking if you disagree.

http://codereview.appspot.com/105045/diff/5/1005
File scm/framework-svg.scm (right):

http://codereview.appspot.com/105045/diff/5/1005#newcode60
Line 60: (dump (ec 'svg))
Just a very very minor thing: IWBN to have eo and ec closer together. For
example, if svg-header just returned the alist of attributes then you could
write
(dump (eo (cons 'svg (svg-header paper)))
...
(dump (ec 'svg))
and it would be totally obvious that they match.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b