Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1026)

Issue 104400045: Reg Tests: XML 01b has an incorrect number of measures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by pkx166h
Modified:
9 years, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Reg Tests: XML 01b has an incorrect number of measures 01b-Pitches-Intervals.xml from the Unofficial MusicXML test suite contains only a single measure in MusicXML, but there should be 41. musicxml2ly is very tolerant here so the error doesn’t show in the pdf. Added missing <measure> elements Fixed a typo in the title Added missing <accidental> elements (They represent the actual notated accidentals. Without these elements there shouldn’t be any visible accidentals. So this is actually a bug in musicxml2ly. The bug doesn’t show here because musicxml2ly interprets the <alter> element which represents the sounding pitch of a note.) Fixes provided by Patrick Schmidt

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -1 line) Patch
M input/regression/musicxml/01b-Pitches-Intervals.xml View 69 chunks +135 lines, -1 line 0 comments Download

Messages

Total messages: 1
pkx166h
9 years, 10 months ago (2014-07-05 05:12:26 UTC) #1
author	Patrick Schmidt <ptrcklschmdt@gmail.com>	
	Sat, 28 Jun 2014 20:24:23 +0000 (21:24 +0100)
committer	James Lowe <pkx166h@gmail.com>	
	Sat, 5 Jul 2014 05:05:02 +0000 (06:05 +0100)
commit	7e4d34a38d70ff6cb9a32b64bc65bbf9439041d1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b