Issue 104054: [PATCH] Use AssertingVH for the GlobalValue maps

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 104054: [PATCH] Use AssertingVH for the GlobalValue maps (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by Jeffrey Yasskin

Modified:
15 years, 5 months ago

Reviewers:
llvm-commits

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Description

To catch bugs like the one fixed in http://llvm.org/viewvc/llvm-project?view=rev&revision=78127, I'm changing the ExecutionEngine's global mappings to hold AssertingVH<const GlobalValue>. That way, if unregistering a mapping fails to actually unregister it, we'll get an assert. Running the jit nightly tests doesn't uncover any actual instances of the problem. This also uncovered the fact that AssertingVH<const X> didn't work, so I fixed that too.

Patch Set 1 #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -19 lines)			Patch
M	include/llvm/ExecutionEngine/ExecutionEngine.h	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	include/llvm/Support/ValueHandle.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	lib/ExecutionEngine/ExecutionEngine.cpp	View	7 chunks	+18 lines, -13 lines	0 comments	Download
M	unittests/Support/ValueHandleTest.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages