LIB Fix b/15114347: Better error message for invalid GSA hostname.

This change provides a more descriptive error message in the log
if the configured GSA is not found at startup.

[pjo, 2014-06-27 01:34:53]

Thank you.

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/Application.java (right):

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/Application.java:154: } catch
(UnknownHostException ex) {
What throws this exception?  Is it gsa.TryToPutVersionIntoConfig?

In which case what do you think if we throw the descriptive message from there
and have it log in the already existing Exception block below?

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/Application.java:172:
gsa.ensureLatestConfigLoaded();
why is this code being moved from inside the exception block?

[Brett, 2014-06-27 22:33:42]

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/Application.java (right):

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/Application.java:154: } catch
(UnknownHostException ex) {
On 2014/06/27 01:34:53, pjo wrote:
> What throws this exception?  Is it gsa.TryToPutVersionIntoConfig?

Yes.  But it is actually coming from GsaVersion.get(), which won't get called if
you specified the gas version in the config properties.

> In which case what do you think if we throw the descriptive message from there
> and have it log in the already existing Exception block below?

I am thinking GsaCommunicationHandler that looks for ConnectionExceptions and
UnknownHostExceptions, etc, and crafts an appropriate IOException message.

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/Application.java:172:
gsa.ensureLatestConfigLoaded();
On 2014/06/27 01:34:53, pjo wrote:
> why is this code being moved from inside the exception block?

The only way to reach this code is to fall through from one of the log, then
retry exceptions.

[pjo, 2014-06-27 23:08:00]

Thank you for your nuanced considerations.

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/Application.java (right):

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/Application.java:154: } catch
(UnknownHostException ex) {
On 2014/06/27 22:33:42, Brett wrote:
> On 2014/06/27 01:34:53, pjo wrote:
> > What throws this exception?  Is it gsa.TryToPutVersionIntoConfig?
> 
> Yes.  But it is actually coming from GsaVersion.get(), which won't get called
if
> you specified the gas version in the config properties.
> 
> > In which case what do you think if we throw the descriptive message from
there
> > and have it log in the already existing Exception block below?
> 
> I am thinking GsaCommunicationHandler that looks for ConnectionExceptions and
> UnknownHostExceptions, etc, and crafts an appropriate IOException message.


How about creating new method, something like:
  gsa.confirmGsaReachable()
  or gsa.confirmHostConnectivity()

https://codereview.appspot.com/103620043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/Application.java:172:
gsa.ensureLatestConfigLoaded();
On 2014/06/27 22:33:42, Brett wrote:
> On 2014/06/27 01:34:53, pjo wrote:
> > why is this code being moved from inside the exception block?
> 
> The only way to reach this code is to fall through from one of the log, then
> retry exceptions.

Yes.  I see.  Thank you.

[Brett, 2014-06-28 02:37:55]

Better messages for GSA communication issues.

[pjo, 2014-06-28 02:42:07]

LGTM.  Thank you.

[Brett, 2014-06-28 03:34:12]

Committed 27 June 2014 to Adaptor Library:

To https://code.google.com/p/plexi/
   6451260..6037ba5  master -> master