Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1182)

Issue 1031044: Doc: Reorganize music functions material. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by Mark Polesky
Modified:
13 years, 10 months ago
Reviewers:
carl.d.sorensen, Neil Puttock, Graham Percival (old account)
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Reorganize music functions material. * Clean up: NR 5.6 "Using music functions" EL 2.1 "Music functions" * In Extending 2.1, move `Void functions' to end of section, so `Functions without arguments' comes first. * Use a consistent indentation format for music functions. * Make some minor formatting/wording changes. * Categorize predicates in type-p-name-alist. * Create type-predicates-doc-string to document type-p-name-alist automatically. * Add notation appendix `Music function type predicates' to include type-predicates-doc-string * Show predicate name instead of "unknown" in type-check error message (from Neil Puttock).

Patch Set 1 #

Total comments: 6

Patch Set 2 : Revert `cheap-list?' changes; tidy up. #

Total comments: 13

Patch Set 3 : Make requested changes. #

Total comments: 7

Patch Set 4 : Update `changing-defaults.itely', `document-type-predicates.scm', and `lily.scm'. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -272 lines) Patch
M Documentation/extending/programming-interface.itely View 1 2 6 chunks +108 lines, -143 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 1 2 3 4 chunks +83 lines, -80 lines 1 comment Download
M Documentation/notation/notation-appendices.itely View 1 2 chunks +7 lines, -0 lines 0 comments Download
M scm/c++.scm View 1 1 chunk +5 lines, -1 line 0 comments Download
A scm/document-type-predicates.scm View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
M scm/documentation-generate.scm View 3 chunks +7 lines, -2 lines 0 comments Download
M scm/lily.scm View 1 2 3 2 chunks +114 lines, -45 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 17
Carl
Everything except your change to cheap-list? looks fine to me. I have some other suggestions, ...
13 years, 11 months ago (2010-04-30 12:17:34 UTC) #1
Mark Polesky
http://codereview.appspot.com/1031044/diff/1/2 File Documentation/extending/programming-interface.itely (right): http://codereview.appspot.com/1031044/diff/1/2#newcode79 Documentation/extending/programming-interface.itely:79: function arguments (eg. @w{@samp{$(cons arg1 arg2)}}). On 2010/04/30 12:17:35, ...
13 years, 11 months ago (2010-04-30 16:21:04 UTC) #2
Neil Puttock
http://codereview.appspot.com/1031044/diff/6001/5002 File Documentation/extending/programming-interface.itely (right): http://codereview.appspot.com/1031044/diff/6001/5002#newcode75 Documentation/extending/programming-interface.itely:75: blocks, use @code{$} to reference function arguments (eg. e.g., ...
13 years, 11 months ago (2010-05-01 12:41:22 UTC) #3
Mark Polesky
http://codereview.appspot.com/1031044/diff/6001/5008 File scm/lily.scm (right): http://codereview.appspot.com/1031044/diff/6001/5008#newcode476 scm/lily.scm:476: ;(,grob::is-live? . "grob::is-live") On 2010/05/01 12:41:23, Neil Puttock wrote: ...
13 years, 11 months ago (2010-05-02 01:46:38 UTC) #4
Neil Puttock
On 2010/05/02 01:46:38, Mark Polesky wrote: > Should I? Initially I thought they should be ...
13 years, 11 months ago (2010-05-03 14:34:35 UTC) #5
Mark Polesky
I've uploaded a new patch set. Okay to push? http://codereview.appspot.com/1031044/diff/6001/5006 File scm/document-type-predicates.scm (right): http://codereview.appspot.com/1031044/diff/6001/5006#newcode55 scm/document-type-predicates.scm:55: ...
13 years, 11 months ago (2010-05-05 01:58:09 UTC) #6
Carl
Mostly looks great! Thanks, Carl http://codereview.appspot.com/1031044/diff/14001/15002 File Documentation/learning/common-notation.itely (left): http://codereview.appspot.com/1031044/diff/14001/15002#oldcode62 Documentation/learning/common-notation.itely:62: This change shouldn't be ...
13 years, 11 months ago (2010-05-06 14:34:54 UTC) #7
Mark Polesky
http://codereview.appspot.com/1031044/diff/14001/15002 File Documentation/learning/common-notation.itely (left): http://codereview.appspot.com/1031044/diff/14001/15002#oldcode62 Documentation/learning/common-notation.itely:62: On 2010/05/06 14:34:54, Carl wrote: > I think you ...
13 years, 11 months ago (2010-05-06 17:45:02 UTC) #8
c_sorensen
On 5/6/10 11:45 AM, "markpolesky@gmail.com" <markpolesky@gmail.com> wrote: > > http://codereview.appspot.com/1031044/diff/14001/15006 > File scm/document-type-predicates.scm (right): > ...
13 years, 11 months ago (2010-05-06 22:50:25 UTC) #9
Mark Polesky
On 2010/05/06 22:50:25, c_sorensen_byu.edu wrote: > The preferred predicate to check for list in lilypond ...
13 years, 11 months ago (2010-05-07 01:43:45 UTC) #10
c_sorensen
On 5/6/10 7:43 PM, "markpolesky@gmail.com" <markpolesky@gmail.com> wrote: > On 2010/05/06 22:50:25, c_sorensen_byu.edu wrote: >> The ...
13 years, 11 months ago (2010-05-07 02:11:27 UTC) #11
c_sorensen
On 5/6/10 7:43 PM, "markpolesky@gmail.com" <markpolesky@gmail.com> wrote: > On 2010/05/06 22:50:25, c_sorensen_byu.edu wrote: >> The ...
13 years, 11 months ago (2010-05-07 02:16:45 UTC) #12
markpolesky_yahoo.com
patch set 4 is up: http://codereview.appspot.com/1031044
13 years, 10 months ago (2010-05-07 08:07:35 UTC) #13
Carl
Looks great! Thanks! Carl http://codereview.appspot.com/1031044/diff/29001/30002 File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/1031044/diff/29001/30002#newcode3630 Documentation/notation/changing-defaults.itely:3630: cheap-list? @emph{(use instead of }@q{list?}@emph{ ...
13 years, 10 months ago (2010-05-07 12:12:43 UTC) #14
Graham Percival (old account)
The patch looks ok, but I'm getting some weird build errors... quite possibly the same ...
13 years, 10 months ago (2010-05-07 12:20:50 UTC) #15
Neil Puttock
LGTM.
13 years, 10 months ago (2010-05-07 20:45:41 UTC) #16
Neil Puttock
13 years, 10 months ago (2010-05-07 20:47:03 UTC) #17
On 2010/05/07 12:20:50, Graham Percival wrote:
> The patch looks ok, but I'm getting some weird build errors... quite possibly
> the same thing Werner noticed (wherein lilypond-book borks if it has two
> identical snippets).

No problems here following a clean build.

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b