Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 10265043: Mostly cosmetic simplifications in woodwind diagrams and library (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by dak
Modified:
10 years, 9 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Mostly cosmetic simplifications in woodwind diagrams and library The woodwind stuff really needs to get rewritten. It is a topsy-turvy contraption where lists are almost but not quite evaluated, lots of oversweeping functionality is defined but not documented and then applied in a manner that can be called nothing but ridiculous. For example, there are "mapping" hooks that only ever return their old value or a constant. There are O(n m) functions for accessing selected keys from a list which are then called with the complete list of keys itself. There is wagonloads of quasiquoting and list juggling going on which might likely better be replaced with inline code. There is no rhyme nor reason behind which functions are made public and which are moved into lily-library. This patch touches at best a few superficial points. It was more intended as a library cleanup but got drawn into the woodwinds as one of the callers of stuff.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -82 lines) Patch
M scm/define-woodwind-diagrams.scm View 6 chunks +37 lines, -59 lines 0 comments Download
M scm/display-woodwind-diagrams.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/lily-library.scm View 3 chunks +6 lines, -22 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b