Updates to NR chapter 1

A set of minor changes to tidy up the NR somewhat.  (Note that there are a number of others that will come from updated snippets in the LSR).

[PhilEHolmes, 2013-06-21 14:00:04]

Please review.

[dak, 2013-06-21 14:11:20]

https://codereview.appspot.com/10237048/diff/1/Documentation/notation/pitches...
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/10237048/diff/1/Documentation/notation/pitches...
Documentation/notation/pitches.itely:1316: \key c \freygish c4 des e f
I was actually surprised at the space being more or less the norm rather than
the exception.  However, the next line would then also be deserving of that
space.

In the tradition of "get offered a morsel, bite off the arm", let me point out
that
git grep '\\key [a-z]\+\\'
points out a few more contenders, including some more in this file:
Documentation/changes.tely:\clef bass \key es\major es g bes d
Documentation/changes.tely:\clef treble \bar "||" \key es\major es g bes d
Documentation/changes.tely:\bar "||" \key d\major b fis b2
Documentation/es/changes.tely:\clef bass \key es\major es g bes d
Documentation/es/changes.tely:\clef treble \bar "||" \key es\major es g bes d
Documentation/es/changes.tely:\bar "||" \key d\major b fis b2
Documentation/es/notation/input.itely:    \key c\minor
Documentation/es/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/es/notation/pitches.itely:  \bar "||" \key d\freygish d es fis g
Documentation/es/notation/pitches.itely:\clef bass \key es\major es g bes d
Documentation/es/notation/pitches.itely:\clef treble \bar "||" \key es\major es
g bes d
Documentation/es/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/fr/notation/input.itely:    \key c\minor
Documentation/fr/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/fr/notation/pitches.itely:  \bar "||" \key d\freygish d es fis g
Documentation/fr/notation/pitches.itely:\clef bass \key es\major es g bes d
Documentation/fr/notation/pitches.itely:\clef treble \bar "||" \key es\major es
g bes d
Documentation/fr/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/fr/notation/pitches.itely:  \key f\major
Documentation/included/engraver-example.ily:  \key d\major
Documentation/included/engraver-example.ily:  \key d\major
Documentation/it/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/it/notation/pitches.itely:  \bar "||" \key d\freygish d es fis g
Documentation/it/notation/pitches.itely:\clef bass \key es\major es g bes d
Documentation/it/notation/pitches.itely:\clef treble \bar "||" \key es\major es
g bes d
Documentation/it/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/ja/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/ja/notation/pitches.itely:  \bar "||" \key d\freygish d es fis g
Documentation/ja/notation/pitches.itely:\clef bass \key es\major es g bes d
Documentation/ja/notation/pitches.itely:\clef treble \bar "||" \key es\major es
g bes d
Documentation/ja/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/notation/input.itely:    \key c\minor
Documentation/notation/pitches.itely:  \key c\freygish c4 des e f
Documentation/notation/pitches.itely:  \bar "||" \key d\freygish d es fis g
Documentation/notation/pitches.itely:\clef bass \key es\major es g bes d
Documentation/notation/pitches.itely:\clef treble \bar "||" \key es\major es g
bes d
Documentation/notation/pitches.itely:\bar "||" \key b\major b fis b2
Documentation/notation/pitches.itely:  \key f\major
Documentation/snippets/adding-links-to-objects.ly:  \key cis\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
Documentation/snippets/vertical-aligned-staffgroups-without-connecting-systemstartbar.ly:
       \key a\minor
input/regression/accidental-clef-change.ly:    \key g\major
input/regression/clip-systems.ly:      \key d\major
input/regression/grace-sync.ly:    \grace {  dis8[ ( d8] \key es\major  }
input/regression/key-signature-space.ly:    \key f\minor
input/regression/key-signature-space.ly:    \key b\major
input/regression/tuplet-full-length.ly:  \bar "|." \key c\minor

so there might be some incentive to factor all those out into one commit
spanning across all manuals and regtests.

[Ian Hulin (gmail), 2013-06-21 16:29:00]

LGTM apart from one nitpick listed below.

Cheers,
Ian

https://codereview.appspot.com/10237048/diff/1/Documentation/notation/simulta...
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/10237048/diff/1/Documentation/notation/simulta...
Documentation/notation/simultaneous.itely:685: below.  Here the note heads on
beat 1 of bar 1 are now merged:
"below.  In this example the note heads on beat 1 of bar 1 are now merged:"

[email_philholmes.net, 2013-06-21 17:20:47]

----- Original Message ----- 
From: <ianhulin44@gmail.com>
To: <PhilEHolmes@googlemail.com>; <dak@gnu.org>
Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com>
Sent: Friday, June 21, 2013 5:29 PM
Subject: Re: Updates to NR chapter 1 (issue 10237048)


> LGTM apart from one nitpick listed below.
>
> Cheers,
> Ian
>
>
>
https://codereview.appspot.com/10237048/diff/1/Documentation/notation/simulta...
> File Documentation/notation/simultaneous.itely (right):
>
>
https://codereview.appspot.com/10237048/diff/1/Documentation/notation/simulta...
> Documentation/notation/simultaneous.itely:685: below.  Here the note
> heads on beat 1 of bar 1 are now merged:
> "below.  In this example the note heads on beat 1 of bar 1 are now
> merged:"
>
> https://codereview.appspot.com/10237048/

OK - I'll fix that.  But bear in mind this is the original text you're 
proposing changing, not anything in this patch.

--
Phil Holmes 

[mail_philholmes.net, 2013-06-21 17:25:40]

----- Original Message ----- 
From: <dak@gnu.org>
To: <PhilEHolmes@googlemail.com>
Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Friday, June 21, 2013 3:11 PM
Subject: Re: Updates to NR chapter 1 (issue 10237048)


>
>
https://codereview.appspot.com/10237048/diff/1/Documentation/notation/pitches...
> File Documentation/notation/pitches.itely (right):
>
>
https://codereview.appspot.com/10237048/diff/1/Documentation/notation/pitches...
> Documentation/notation/pitches.itely:1316: \key c \freygish c4 des e f
> I was actually surprised at the space being more or less the norm rather
> than the exception.  However, the next line would then also be deserving
> of that space.

For me, the best bet would be to push the patch as is (subject to other 
review) and then fix the lack of space before key sigs as a separate patch, 
which I'll do.

I've fixed a number in the LSR and will push that tomorrow, when the tarball 
is available.

--
Phil Holmes 

[Trevor Daniels, 2013-06-24 06:56:11]

LGTM, with one suggestion.

https://codereview.appspot.com/10237048/diff/1/Documentation/notation/pitches...
File Documentation/notation/pitches.itely (right):

https://codereview.appspot.com/10237048/diff/1/Documentation/notation/pitches...
Documentation/notation/pitches.itely:1317: \bar "||" \key d\freygish d es fis g
May as well do this one in this patch, though.

[Graham Percival, 2013-06-24 08:50:49]

LGTM