Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2811)

Issue 10131044: convert-ly: Flag.transparent and Flag.color inherit from Stem (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by dak
Modified:
10 years, 9 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

convert-ly: Flag.transparent and Flag.color inherit from Stem After issue 3395, Flag color and transparency does not need to be changed in synch with Stem color and transparency. Strictly speaking, it is overkill to change synchronized reverts along with synchronized overrides: this does not work with things like \override Stem.color = #red \override Flag.color = #blue ... \revert Stem.color \revert Flag.color where only the reverts get conflated (and thus Flag color stays in place). That's less than perfect, but probably better than leaving reverts alone (for Flag.transparent, they might have been created automatically by an earlier convert-ly rule). Also (obviously) contains commit Run scripts/auxiliar/update-with-convert-ly.sh

Patch Set 1 #

Patch Set 2 : Also treat overrides with context identifier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -195 lines) Patch
M Documentation/cs/learning/tweaks.itely View 5 chunks +1 line, -5 lines 0 comments Download
M Documentation/de/learning/tweaks.itely View 4 chunks +1 line, -4 lines 0 comments Download
M Documentation/de/notation/ancient.itely View 1 12 chunks +2 lines, -13 lines 0 comments Download
M Documentation/de/notation/changing-defaults.itely View 4 chunks +1 line, -4 lines 0 comments Download
M Documentation/de/notation/percussion.itely View 6 chunks +1 line, -6 lines 0 comments Download
M Documentation/es/learning/tweaks.itely View 5 chunks +1 line, -5 lines 0 comments Download
M Documentation/es/notation/ancient.itely View 1 12 chunks +2 lines, -13 lines 0 comments Download
M Documentation/es/notation/changing-defaults.itely View 4 chunks +1 line, -4 lines 0 comments Download
M Documentation/es/notation/percussion.itely View 6 chunks +1 line, -6 lines 0 comments Download
M Documentation/fr/learning/tweaks.itely View 5 chunks +1 line, -5 lines 0 comments Download
M Documentation/fr/notation/ancient.itely View 1 12 chunks +2 lines, -13 lines 0 comments Download
M Documentation/fr/notation/changing-defaults.itely View 4 chunks +1 line, -4 lines 0 comments Download
M Documentation/fr/notation/percussion.itely View 6 chunks +1 line, -6 lines 0 comments Download
M Documentation/it/learning/tweaks.itely View 5 chunks +1 line, -5 lines 0 comments Download
M Documentation/ja/learning/tweaks.itely View 5 chunks +1 line, -5 lines 0 comments Download
M Documentation/ja/notation/changing-defaults.itely View 4 chunks +1 line, -4 lines 0 comments Download
M Documentation/ja/notation/percussion.itely View 6 chunks +1 line, -6 lines 0 comments Download
M Documentation/learning/tweaks.itely View 5 chunks +1 line, -5 lines 0 comments Download
M Documentation/ly-examples/bach-schenker.ly View 15 chunks +1 line, -22 lines 0 comments Download
M Documentation/ly-examples/cary.ly View 2 chunks +1 line, -2 lines 0 comments Download
M Documentation/nl/learning/tweaks.itely View 5 chunks +1 line, -5 lines 0 comments Download
M Documentation/notation/ancient.itely View 1 12 chunks +2 lines, -13 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 4 chunks +1 line, -4 lines 0 comments Download
M Documentation/notation/percussion.itely View 6 chunks +1 line, -6 lines 0 comments Download
M Documentation/snippets/ancient-notation-template----modern-transcription-of-gregorian-music.ly View 2 chunks +1 line, -2 lines 0 comments Download
M Documentation/snippets/guitar-slides.ly View 2 chunks +1 line, -2 lines 0 comments Download
M Documentation/snippets/jazz-combo-template.ly View 2 chunks +1 line, -3 lines 0 comments Download
M Documentation/snippets/new/ancient-notation-template----modern-transcription-of-gregorian-music.ly View 2 chunks +1 line, -2 lines 0 comments Download
M Documentation/snippets/new/guitar-slides.ly View 2 chunks +1 line, -2 lines 0 comments Download
M Documentation/snippets/new/jazz-combo-template.ly View 2 chunks +1 line, -3 lines 0 comments Download
M Documentation/snippets/new/score-for-diatonic-accordion.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/score-for-diatonic-accordion.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/grid-lines.ly View 2 chunks +1 line, -2 lines 0 comments Download
M ly/gregorian.ly View 2 chunks +1 line, -2 lines 0 comments Download
M ly/property-init.ly View 4 chunks +1 line, -8 lines 0 comments Download
M python/convertrules.py View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 1
dak
10 years, 10 months ago (2013-06-09 11:31:04 UTC) #1
Also treat overrides with context identifier
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b